Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split JARs, one for libraries and the other for execution #29

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented Apr 15, 2023

@khatchad khatchad changed the title Address https://github.com/wala/ML/issues/28. Split JARs, one for libraries and the other for execution Apr 15, 2023
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msridhar msridhar merged commit 9e935bf into wala:master Apr 15, 2023
@khatchad khatchad deleted the shading branch April 27, 2023 16:47
khatchad referenced this pull request in ponder-lab/ML May 23, 2023
* Address wala#28. (#29)

See https://maven.apache.org/plugins/maven-shade-plugin/examples/attached-artifact.html for reference.

* Remove unused footnote. (#31)

Forgot to remove this one with the last update.

* Lowercase parent pom artifact ID. (#32)

Fixes wala#30.

* Fix wala#33. (#34)

Make consistent by using Jython 3 as a dependency.

* Metadata, build script, and warnings (#35)

* Remove obsolete bundles.

These are being used as JARs now.

* Export missing packages.

Since wala/ML is now using JAR packaging, this probably doesn't matter.
However, it fixes the warnings. And, if it ever gets OSGi component
packaged again, we can use it.

* Fix build.properities file.

Source and data directiories don't exist for these subprojects.

* Fix more warnings.

* Use verify to run the tests.

* Export more packages.

* Fix generics hiding warning.

* Fix Jython and Jython3 test directory metadata.

* Add GH actions file (#40)

* Add GH actions file.

* Remove optional dependency analysis.

Was failing.

* Fix path.

* Switch Jython repos.

* Revert "Switch Jython repos."

This reverts commit 20052de.

* Print out the stack trace.

* Switch to Jython3 for testing ML.

* Revert "Print out the stack trace."

This reverts commit 8fb7951.

* Update run.sh

Fix broken resolution.

* Ignore failing test.

Reinstate once wala#42 is fixed.

* Revert "Work around https://github.com/ponder-lab/ML/issues/4."

This reverts commit 0e5c334.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants