-
Notifications
You must be signed in to change notification settings - Fork 18
Fix tensor dimensions for Jython 3 #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tensor dimensions for Jython 3 #261
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
============================================
+ Coverage 54.97% 58.50% +3.53%
- Complexity 502 517 +15
============================================
Files 109 109
Lines 7684 7286 -398
Branches 827 827
============================================
+ Hits 4224 4263 +39
+ Misses 3223 2847 -376
+ Partials 237 176 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...m.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java
Show resolved
Hide resolved
...m.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java
Show resolved
Hide resolved
...m.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java
Show resolved
Hide resolved
...m.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflow2Model.java
Show resolved
Hide resolved
@khatchad lost track of this one is it still waiting on a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick
com.ibm.wala.cast.python.jython3/source/com/ibm/wala/cast/python/loader/Python3Loader.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses multiple issues related to tensor dimensions for Jython 3 by updating Maven dependencies, renaming artifacts, and adding logging to improve traceability and error handling. Key changes include:
- Adding new dependencies (asm-all and jnr-constants) to support the updated API.
- Renaming Jython-related artifactId references to their Jython 3 counterparts.
- Enhancing logging in Python3Loader to better capture expression evaluations and syntax errors.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
com.ibm.wala.cast.python.test/pom.xml | Added dependencies for asm-all and jnr-constants to support new API requirements |
com.ibm.wala.cast.python.ml/pom.xml | Updated artifactId from jython to jython3 to match Jython 3 API |
com.ibm.wala.cast.python.ml.test/pom.xml | Updated artifactId from jython.test to jython3.test for consistency |
com.ibm.wala.cast.python.jython3/source/com/ibm/wala/cast/python/util/Python3Interpreter.java | Removed try-catch block during Python interpreter initialization |
com.ibm.wala.cast.python.jython3/source/com/ibm/wala/cast/python/loader/Python3Loader.java | Added enhanced logging for expression evaluation and syntax error handling |
com.ibm.wala.cast.python.jython3/source/com/ibm/wala/cast/python/util/Python3Interpreter.java
Show resolved
Hide resolved
Thanks! |
Fix #42 and fix #147 and fix #165 and fix #164 and fix #166.