Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and changes for decorators #193

Merged
merged 7 commits into from
May 26, 2024
Merged

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented May 2, 2024

  • Decorator testing.
  • Actually capture the decorated function for @tf.function decorated functions.
  • Add pytest.mark.skip summary.
  • Use pytest summary for all Python analysis. There are some decorators it may work for.
    • Test pytest decorator.

- Decorator testing.
- Actually capture the decorated function for @tf.function decorated functions.
- Add `pytest.mark.skip` summary.
- Use pytest summary for all Python analysis. There are some decorators it may work for.
  - Test pytest decorator.
@khatchad khatchad enabled auto-merge (squash) May 2, 2024 16:09
@khatchad khatchad requested a review from msridhar May 2, 2024 16:09
@khatchad khatchad added bug Something isn't working enhancement New feature or request testing Related to test code or test input decorators labels May 2, 2024
@khatchad khatchad marked this pull request as draft May 2, 2024 16:12
auto-merge was automatically disabled May 2, 2024 16:12

Pull request was converted to draft

@khatchad khatchad marked this pull request as ready for review May 2, 2024 16:29
@khatchad khatchad enabled auto-merge (squash) May 2, 2024 16:29
@msridhar
Copy link
Member

@khatchad sorry for the slow review here, I'll wait until conflicts are resolved and then take a look.

@khatchad
Copy link
Collaborator Author

@khatchad sorry for the slow review here, I'll wait until conflicts are resolved and then take a look.

Sorry for my slow response, @msridhar! I believe I've now resolved them.

@khatchad khatchad merged commit 60955d6 into wala:master May 26, 2024
1 check passed
@khatchad khatchad deleted the contrib_decorators branch May 26, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working decorators enhancement New feature or request testing Related to test code or test input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants