Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous updates #192

Merged
merged 14 commits into from
May 14, 2024
Merged

Miscellaneous updates #192

merged 14 commits into from
May 14, 2024

Conversation

khatchad
Copy link
Collaborator

@khatchad khatchad commented May 2, 2024 •
edited
Loading

  • Add tests.
  • Fix comments.
  • Extract method.
  • Capitalize constant.
  • Shorten name.
  • Remove explicit super call.
    It's called implicitly.

@khatchad khatchad enabled auto-merge (squash) May 2, 2024 15:53
@khatchad khatchad marked this pull request as draft May 2, 2024 15:54
auto-merge was automatically disabled May 2, 2024 15:54

Pull request was converted to draft

@khatchad khatchad marked this pull request as ready for review May 2, 2024 16:02
@khatchad khatchad enabled auto-merge (squash) May 2, 2024 16:02
@khatchad khatchad requested a review from msridhar May 2, 2024 16:03
@khatchad khatchad merged commit 859e413 into wala:master May 14, 2024
1 check passed
@khatchad khatchad deleted the contrib_misc4 branch May 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khatchad @msridhar