Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for resolving wildcard imports #169

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

khatchad
Copy link
Collaborator

Fixes #65 for both libraries and (internal) "scripts."

* Add tests.

* More tests for wala#65.

* Hack it.

* More tests.

* More tests.

* Revert "Hack it."

This reverts commit 13f6c78. Do it
through the PA instead.

* Progress.

* Remove warning suppression.

We're using the logger now.

* More tests.

* Add logging.

* Progress.

* Another transitive test.

* Only traverse the queue.

We still need it.

* Check if the value is a constant first.

* Rearrange.

* Short circuit when we find the import.

Use only the first found library.

* Generalize.

* Move CG assertions after dump.

* Cleanup variables.

* Remove unnecessarily method call.

* Move variables out.

* Progress.

* Cleanup.

* Update test.
@khatchad khatchad added bug Something isn't working enhancement New feature or request labels Mar 16, 2024
@khatchad khatchad requested a review from msridhar March 16, 2024 12:16
@khatchad khatchad enabled auto-merge (squash) March 18, 2024 16:42
@khatchad khatchad merged commit 3ded12f into wala:master Mar 19, 2024
1 check passed
@khatchad khatchad deleted the contrib_wildcard_imports branch March 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve wildcard imports
2 participants