chore: easy setup fleets for lpt #3125
Conversation
NagyZoltanPeter
requested review from
Ivansete-status,
gabrielmer,
fryorcraken,
darshankabariya and
richard-ramos
…g service peers if failed with original
…ity and availability, dashboard adjustments
NagyZoltanPeter
force-pushed
the
chore-easy-setup-fleets-for-lpt
branch
from
b0a1a05
to
460f561
Compare
|
You can find the image built from this PR at Built from c6e2b4e |
…ager's peerStore to wakuPeerStore
|
|
||
| return ok(peerInfo) | ||
|
|
||
| randomize() |
There was a problem hiding this comment.
Do we want this call on a global scope or inside a proc? if it's globally, better to put it before every proc definition so it's easier to see
| elif codec.contains("filter"): | ||
| capability = Capabilities.Filter |
There was a problem hiding this comment.
isn't this elif redundant if capability is already initialized to Capabilities.Filter?
Same in selectRandomCapablePeer
| var found = none(RemotePeerInfo) | ||
| var okPeers: seq[RemotePeerInfo] = @[] | ||
|
|
||
| while found.isNone() and supportivePeers.len > 0: |
There was a problem hiding this comment.
I think we don't even update found in this proc, it's very similar to selectRandomCapablePeer - not sure if it's better to avoid the code duplication by having all that same logic in a same place
Actually, I think we don't use selectRandomCapablePeer anywhere 😶
| if connOpt.value().isSome(): | ||
| found = some(randomPeer) | ||
| debug "Dialing successful", | ||
| peer = constructMultiaddrStr(randomPeer), codec = codec | ||
| else: | ||
| debug "Dialing failed", peer = constructMultiaddrStr(randomPeer), codec = codec |
There was a problem hiding this comment.
Shouldn't we do here
lpt_dialed_peers.inc()
and
lpt_dial_failures.inc()
like in tryCallAllPxPeers?
| if conf.bootstrapNode.len > 0: | ||
| info "Bootstrapping with PeerExchange to gather random service node" | ||
| let futForServiceNode = pxLookupServiceNode(wakuApp.node, conf) | ||
| if not (waitFor futForServiceNode.withTimeout(20.minutes)): |
There was a problem hiding this comment.
waitFor with 20 mins timeout? 😱
| # so we will mount PeerExchange to gather possible service peers, if got some | ||
| # we will mount the client protocols afterward. | ||
| wakuConf.peerExchange = false |
There was a problem hiding this comment.
not sure I understand - according to the comment, shouldn't wakuConf.peerExchange be set to true?
| proc `$`*(cap: Capabilities): string = | ||
| case cap | ||
| of Capabilities.Relay: | ||
| return "Relay" | ||
| of Capabilities.Store: | ||
| return "Store" | ||
| of Capabilities.Filter: | ||
| return "Filter" | ||
| of Capabilities.Lightpush: | ||
| return "Lightpush" | ||
| of Capabilities.Sync: | ||
| return "Sync" |
There was a problem hiding this comment.
It might be worth having this proc in waku/waku_enr/capabilities.nim so it can be used in other places too :)
Co-authored-by: gabrielmer <101006718+gabrielmer@users.noreply.github.com>
Description
A greater upgrade for liteprotocoltester.
Changes
Extension
A new repository https://github.com/waku-org/lpt-runner created to ease the usage and run against various waku networks and fleets.
Issue
#2999