Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci - force use ubuntu-22.04 #3118

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: ci - force use ubuntu-22.04 #3118

merged 1 commit into from
Oct 15, 2024

Conversation

Ivansete-status
Copy link
Collaborator

No description provided.

@Ivansete-status Ivansete-status changed the title chore: ci - for use ubuntu-22.04 chore: ci - force use ubuntu-22.04 Oct 15, 2024
@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3118

Built from d4e99aa

@Ivansete-status Ivansete-status marked this pull request as ready for review October 15, 2024 15:11
gabrielmer
gabrielmer approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graciasss

NagyZoltanPeter
NagyZoltanPeter approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do we need sudo apt-get install -y libpcre3 libpcre3-dev still?

@Ivansete-status
Copy link
Collaborator Author

LGTM! Do we need sudo apt-get install -y libpcre3 libpcre3-dev still?

Very good point indeed! I think it shouldn't be needed now

@Ivansete-status Ivansete-status merged commit 18c375a into master Oct 15, 2024
12 of 14 checks passed
@Ivansete-status Ivansete-status deleted the use-fixed-ubuntu-22.04-ci branch October 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivansete-status @gabrielmer @NagyZoltanPeter