fix: add a limit of max 10 content topics per query #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
SionoiS,
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from 6120074 |
NagyZoltanPeter
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
In general it is ok and need to protect the interface, but I think it might worth to measure where the perf drops, due otherwise it can lead to too many queries, that will in contradict increase the overall load.
Also will be interesting to see how to properly set rate limit for store that still serve the clients (like Status app using a lots of content-topics) but does not allow DOS the node.
Ivansete-status
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the same restriction we had on waku archive legacy of a maximum of 10 content topics per query as it currently was limitless. We have seen that the store query performance drops the more content topics we add so adding a limit of 10 will help avoid this situation as well as comply with the current assumptions of status-go