chore: improving and temporarily skipping flaky rln test #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from db54d8b |
gabrielmer
changed the title
gabrielmer
requested review from
richard-ramos,
darshankabariya,
NagyZoltanPeter and
Ivansete-status
Ivansete-status
approved these changes
Oct 7, 2024
NagyZoltanPeter
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For quite a while, the test
WakuNode - RLN relay::clearNullifierLog: should clear epochs > MaxEpochGaphas been extremely flaky in the CI.I added in this PR a small fix to make the test more deterministic, however I still see that it's a bit flaky anyways.
So I propose to skip this test in the meantime until we get to work on it, and opened the following issue to track it #3095
Changes
startTime