Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store clients with --store=false does not install Store Client JSON-RPC API handlers #1382

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: store clients with --store=false does not install Store Client JSON-RPC API handlers #1382

merged 1 commit into from
Nov 15, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 15, 2022

This PR resolves #1381

  • The JSON RPC handlers for filter and store are installed if the corresponding storenode and filternode configuration parameters are provided.

This fix affects to wakunode2 and wakubridge apps.

@LNSD LNSD requested review from alrevuelta and jm-clius November 15, 2022 12:41
@LNSD LNSD self-assigned this Nov 15, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 15, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 241b229 #1 2022-11-15 12:57:14 ~15 min macos 📦bin
✔️ 241b229 #1 2022-11-15 12:58:48 ~17 min linux 📦bin

jm-clius
jm-clius approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should do the trick.

@LNSD LNSD merged commit f1ab147 into master Nov 15, 2022
@LNSD LNSD deleted the fix-jsonrpc-store-client branch November 15, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@LNSD LNSD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: store clients with --store=false does not install Store Client JSON-RPC API handlers
3 participants
@LNSD @status-im-auto @jm-clius