Skip to content

bug: Node setup complete even --store-message-db-url is wrong #3018

Open

Description

Problem

nWaku completes the setup even flag --store-message-db-url is set up wrong.

To reproduce

Assuming a correct node setup, change the --store-message-db-url from a correct one like
"postgres://postgres:wakupassword@127.0.0.1:5432/postgres"
to
"postgresql://postgres:wakupassword@127.0.0.1:5432/postgres"

Expected behavior

The node should fail the setup, as the url is not existent.

nwaku version/commit hash

v0.32.0-rc.2

Additional context

Maybe is something related to how you handle the URL in the parsing of the flags, this should be easy to check.
What worries me a little bit more is even at startup if the flag value is not checked correctly, how nWaku is not crashing or logging errors afterwards, when it is supposed to have --store=true and should be archiving messages. Because in my case, the node was working correctly, but it was not saving messages in the DB.

CC: thx to @Ivansete-status for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingeffort/hoursEstimated to be completed in a few hours

    Type

    No type

    Projects

    • Status

      To Do

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions