Skip to content

bug: failed to store peers to persistent storage #2792

Open

Description

Problem

During interop test_use_persistent_storage_survive_restart execution, docker container reported an error:

WRN 2024-06-07 19:05:37.208+00:00 failed to store peers topics="waku node peer_manager" tid=1 file=peer_manager.nim:117 err="peer info encoding failed: Enncoding public key failed: KeyError"

Database files to store peers were created:
-rw-r--r-- 1 root root 4096 Jun 8 07:25 peers.db
-rw-r--r-- 1 root root 32768 Jun 8 07:25 peers.db-shm
-rw-r--r-- 1 root root 8272 Jun 8 07:25 peers.db-wal

Impact

Not clear yet. Not sure if the peers were actually stored or not. The test relies on the assumption that storage is reliable.

To reproduce

  1. Please checkout waku-org/waku-interop-tests@909274d
  2. cd waku-interop-tests
  3. python -m venv .venv
  4. source .venv/bin/activate
  5. pip install -r requirements.txt
  6. pre-commit install
  7. edit src/env_vars.py
    NODE_1 = get_env_var("NODE_1", DEFAULT_NWAKU)
  8. pytest tests/peer_connection_management/test_peer_store.py -k 'test_use_persistent_storage_survive_restart'

Expected behavior

Confirmation wether peers were actually stored or not. And it would be cool to have a non root folder as a destination for the database files. It somewhat interesting idea to start fresh node process over shared storage and kill the unresponsive node process.

Screenshots/logs

node1_2024-06-07_21-05-34.log

nwaku version

wakuorg/nwaku: wakunode2-v0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

  • Status

    To Do

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions