Skip to content

bug: ENR shouldn't be used for pruning #2594

Open

Description

Problem

PeerManager.prunePeer should not use ENR as it's easy to fake.

Impact

Low

To reproduce

https://github.com/waku-org/nwaku/blob/master/waku/node/peer_manager/peer_manager.nim#L852-L853

Expected behavior

Instead of ENR, GossipSub.peerStats could be an option.

nwaku version/commit hash

wakunode2: v0.24.0-rc.0-126-g4117fe
branch: test-peer-connection-management
commit: bbebbac (might change in the future)

CC: @alrevuelta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugSomething isn't workingeffort/daysEstimated to be completed in a few days, less than a week

Type

No type

Projects

  • Status

    Icebox

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions