fix: filter batch duration opt was not propagated correctly #1224
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
force-pushed
the
fix/filter-batch-duration
branch
from
f4337f0
to
e057f4b
Compare
richard-ramos
approved these changes
Sep 20, 2024
kaichaosun
approved these changes
Sep 20, 2024
chaitanyaprem
force-pushed
the
fix/filter-batch-duration
branch
from
e057f4b
to
7956fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix made in release branch to update filter batch duration ticker to 300ms was not propagated correctly in the code that is moved to go-waku.
this PR addresses the gaps in the fix propagation.
Changes