fix: protocolID must be a string in the mobile API (#466)

waku-org · Feb 20, 2023 · a1edf45 · a1edf45
1 parent 54005c8
commit a1edf45
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/library/api.go b/library/api.go
@@ -9,7 +9,6 @@ import "C"
 import (
 	"unsafe"
 
-	libp2pProtocol "github.com/libp2p/go-libp2p/core/protocol"
 	mobile "github.com/waku-org/go-waku/mobile"
 	"github.com/waku-org/go-waku/waku/v2/protocol"
 )
@@ -90,7 +89,7 @@ func waku_listen_addresses() *C.char {
 //
 //export waku_add_peer
 func waku_add_peer(address *C.char, protocolID *C.char) *C.char {
-	response := mobile.AddPeer(C.GoString(address), libp2pProtocol.ID(C.GoString(protocolID)))
+	response := mobile.AddPeer(C.GoString(address), C.GoString(protocolID))
 	return C.CString(response)
 }
 

diff --git a/mobile/api.go b/mobile/api.go
@@ -321,7 +321,7 @@ func ListenAddresses() string {
 	return PrepareJSONResponse(addresses, nil)
 }
 
-func AddPeer(address string, protocolID libp2pProtocol.ID) string {
+func AddPeer(address string, protocolID string) string {
 	if wakuState.node == nil {
 		return MakeJSONResponse(errWakuNodeNotReady)
 	}
@@ -331,7 +331,7 @@ func AddPeer(address string, protocolID libp2pProtocol.ID) string {
 		return MakeJSONResponse(err)
 	}
 
-	peerID, err := wakuState.node.AddPeer(ma, protocolID)
+	peerID, err := wakuState.node.AddPeer(ma, libp2pProtocol.ID(protocolID))
 	return PrepareJSONResponse(peerID, err)
 }