-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(v3/macos): guard InvisibleTitleBarHeight and fix top-corner resize shaking #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e shaking (#4960) - Only apply InvisibleTitleBarHeight when the native drag area is actually hidden (frameless window or transparent title bar presets like HiddenInset). Previously it was applied unconditionally, which could swallow clicks near the top of standard windows. - Skip drag initiation when the click is near the left/right window edges within the invisible title bar zone. This prevents conflict between dragging and native top-corner resizing, which caused window content to shake/jitter. Fixes #4960 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
WalkthroughApply InvisibleTitleBarHeight only for windows that are frameless or use AppearsTransparent; skip initiating a window drag when a title-bar-area click is within 5 points of the left/right window edges to prevent top-corner resize jitter. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a window shaking issue on macOS when resizing from top corners with transparent/hidden title bar presets. It also prevents InvisibleTitleBarHeight from interfering with standard title bar windows.
Changes:
- Added guard condition to only apply
InvisibleTitleBarHeightwhen the native drag area is hidden (frameless or transparent title bar) - Added edge detection logic to skip drag initiation near left/right window edges to prevent conflict with native corner resizing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| v3/pkg/application/webview_window_darwin.go | Added conditional check to only apply invisible title bar height for frameless or transparent title bar windows |
| v3/pkg/application/webview_window_darwin.m | Added resize threshold check to prevent drag initiation near window edges, fixing top-corner resize shaking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying wails with
|
| Latest commit: |
00753e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://45451abb.wails.pages.dev |
| Branch Preview URL: | https://v3-bugfix-invisible-titlebar.wails.pages.dev |
Document that InvisibleTitleBarHeight only applies to frameless or transparent title bar windows, and add changelog entries for the guard and edge-detection fixes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
InvisibleTitleBarHeightwhen the native drag area is actually hidden (frameless window or transparent title bar presets likeMacTitleBarHiddenInset/MacTitleBarHiddenInsetUnified). Previously it was applied unconditionally, which could swallow clicks near the top of standard windows.Test plan
InvisibleTitleBarHeightstill drags correctlyMacTitleBarHiddenInset+InvisibleTitleBarHeightstill drags correctlyInvisibleTitleBarHeightif accidentally setFixes #4960
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation