Fix drag and drop missing cursor icon #3703
Conversation
WalkthroughThe changes involve modifications to the drag-and-drop functionality within the application, specifically enhancing user feedback by setting the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
website/src/pages/changelog.mdx (1)
29-29: Ensure consistency in changelog entry format.The changelog entry for the drag-and-drop cursor icon fix should maintain consistency with the format used in other entries. Consider adding more context or details if necessary.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- v2/internal/frontend/runtime/desktop/draganddrop.js (1 hunks)
- v2/internal/frontend/runtime/runtime_debug_desktop.js (1 hunks)
- website/src/pages/changelog.mdx (1 hunks)
Additional comments not posted (8)
v2/internal/frontend/runtime/desktop/draganddrop.js (7)
54-54: LGTM! The change to setdropEffectis appropriate.Setting
e.dataTransfer.dropEffect = 'copy';ensures that the cursor icon correctly indicates a copy action during drag-and-drop operations. This aligns with the PR objectives to fix the cursor icon issue.
Line range hint
70-102: No changes detected inonDragLeave.The function implementation appears correct and aligns with its intended purpose.
Line range hint
104-132: No changes detected inonDrop.The function implementation appears correct and aligns with its intended purpose.
Line range hint
134-137: No changes detected inCanResolveFilePaths.The function implementation appears correct and aligns with its intended purpose.
Line range hint
139-149: No changes detected inResolveFilePaths.The function implementation appears correct and aligns with its intended purpose.
Line range hint
151-193: No changes detected inOnFileDrop.The function implementation appears correct and aligns with its intended purpose.
Line range hint
195-202: No changes detected inOnFileDropOff.The function implementation appears correct and aligns with its intended purpose.
v2/internal/frontend/runtime/runtime_debug_desktop.js (1)
457-457: LGTM! Verify drag-and-drop functionality.The change to set
e.dataTransfer.dropEffect = 'copy';ensures the correct cursor icon is displayed during drag-and-drop operations. This aligns with the PR objectives and resolves the linked issue #3702.However, verify that this change does not introduce any side effects or break existing functionality in different environments.
Run the following script to verify the drag-and-drop functionality:
|
Thanks for this! 🙏 |
* fix: darg and drop missing cursor icon * chore: update change log
Description
Fix the missing drag and drop missing cursor icon by setting it before preventing the
onDragOver()event.Fixes #3702
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally, after the fix:
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksSummary by CodeRabbit
New Features
Bug Fixes
Documentation