Fix doctor command not finding pkg-config on Solus #3670
Conversation
WalkthroughThis update primarily changes the identification of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
v2/internal/system/packagemanager/eopkg.go (1)
43-43: Update all occurrences of "pkg-config" to ensure consistencyThe change from "pkg-config" to "pkgconf" in
eopkg.gois not isolated. Other parts of the codebase still use "pkg-config", which could lead to inconsistencies. Consider updating the following occurrences:
v2/internal/system/system.go: Update the command execution to use "pkgconf" if applicable.v2/internal/system/system_linux.go: Ensure the dependency check aligns with the new package name.v2/internal/system/packagemanager/dnf.go: Verify if "pkgconf-pkg-config" is the intended package.v2/internal/system/packagemanager/apt.go: Update the package name if "pkgconf" is the correct package.v2/internal/system/packagemanager/nixpkgs.go: Ensure the package naming aligns with "pkgconf".v2/internal/system/packagemanager/pacman.go: Verify the use of "pkgconf".v2/internal/system/packagemanager/emerge.go: Confirm "dev-util/pkgconf" is correct.v2/internal/system/packagemanager/zypper.go: Ensure consistency with "pkgconf-pkg-config".v2/internal/system/packagemanager/packagemanager.go: Update the command execution and version check.Analysis chain
LGTM! Verify the impact of the
pkgconfchange.The change from
"pkg-config"to"pkgconf"is approved and aligns with the PR objectives.Ensure that this change does not affect other parts of the codebase that might rely on the old package name.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of changing "pkg-config" to "pkgconf" in the codebase. # Test: Search for occurrences of "pkg-config" in the codebase. Expect: No remaining occurrences. rg --type go '"pkg-config"'Length of output: 1156
Script:
#!/bin/bash # Description: Review each file where "pkg-config" is mentioned to determine if they should be updated to "pkgconf". # List files with "pkg-config" and show context around each occurrence. rg --type go '"pkg-config"' -A 3 -B 3Length of output: 5867
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- v2/internal/system/packagemanager/eopkg.go (1 hunks)
- website/src/pages/changelog.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
- website/src/pages/changelog.mdx
* Fix doctor command not finding pkg-config on Solus * Update changelog
Description
Fixed
wails doctornot findingpkg-configon Solus.On Solus,
pkg-confighas been replaced by the backwards compatiblepkgconfpackage. As Solus is a rolling release, it should be safe to update the looked up package name frompkg-configtopkgconf, especially aswails doctoris informational and does not affect whetherwails buildetc can findpkg-config.Before Fix:
After Fix:
Fixes #3669
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran
wails doctoron an up to date Solus install, wherewails buildworks fine. 😄Test Configuration
See screenshots!
Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
New Features
Documentation