Fix build for Linux/v2.9.0

[leaanthony]

Description

This PR adds a fix for compilation errors on Linux. Pipelines updated to test on both 22.04 and 24.04.

Fixes #3542

Summary by CodeRabbit

• Chores
  • Updated continuous integration workflows to include support for ubuntu-22.04 and ubuntu-24.04.
  • Added steps to install Linux dependencies and run tests for new Ubuntu versions.
  • Modified job execution matrix to replace ubuntu-latest with ubuntu-22.04 and ubuntu-24.04.
  • Updated Go version to 1.21 in workflow configurations.

[cloudflare-workers-and-pages]

Deploying wails with    Cloudflare Pages

Latest commit:	52583cb
Status:	✅  Deploy successful!
Preview URL:	https://5ef26eec.wails.pages.dev
Branch Preview URL:	https://v2-bugfix-3542.wails.pages.dev

View logs

[coderabbitai]

Warning

Rate limit exceeded

@leaanthony has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 21 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 750d60a and 52583cb.

Walkthrough

The recent updates focus largely on expanding support to newer Ubuntu versions within the CI workflows and fixing a specific Linux-related bug in the window.c file. Notably, the workflows in .github/workflows/build-and-test.yml and .github/workflows/pr.yml now accommodate ubuntu-22.04 and ubuntu-24.04 with corresponding steps to install dependencies, run tests, and build templates. Additionally, an outdated call in window.c was corrected to improve build stability on Linux.

Changes

Files	Change Summary
.github/workflows/build-and-test.yml	- Updated OS matrix to include ubuntu-22.04 and ubuntu-24.04 - Modified steps for Linux dependencies - Added test steps for ubuntu-24.04 - Expanded OS matrix for another job to include ubuntu-22.04 and ubuntu-24.04
.github/workflows/pr.yml	- Updated OS matrix strategy to use ubuntu-22.04 and ubuntu-24.04 - Updated go-version to 1.21 - Added steps for Linux dependencies installation for ubuntu-22.04 and ubuntu-24.04
...frontend/desktop/linux/window.c	- Modified SetupWebview function to remove G_OBJECT cast on webview parameter

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Ensure CI workflows support newer Ubuntu versions (#3542)	✅
Fix wails 2.9.0 Linux issue preventing building and running (#3542)	✅

Poem

🐰 Amidst the code, a bunny hops,
To newer Ubuntus, support now props.
Building strong and running fast,
Wails on Linux, errors past.
In flow, the code doth gracefully dance,
With the rabbit's touch, enhance! 🌿

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fdbfdef and 0107429.

Files selected for processing (3)

• .github/workflows/build-and-test.yml (4 hunks)
• .github/workflows/pr.yml (1 hunks)
• v2/internal/frontend/desktop/linux/window.c (1 hunks)

Files skipped from review due to trivial changes (1)

• v2/internal/frontend/desktop/linux/window.c

Additional comments not posted (6)

.github/workflows/pr.yml (2)

58-59: Updated Go version and OS in the matrix for testing.

Please ensure that all dependencies are compatible with Go 1.21 as this is a significant version change.

---

65-66: Added steps to install Linux dependencies for Ubuntu 22.04 and 24.04.

Ensure that all required packages are available in the repositories for these Ubuntu versions, especially libwebkit2gtk-4.1-dev for Ubuntu 24.04, which might differ from earlier versions.

Also applies to: 69-71

.github/workflows/build-and-test.yml (4)

15-15: Expanded OS matrix to include Ubuntu 22.04 and 24.04.

This change aligns with the PR’s goal to ensure compatibility across newer Ubuntu versions. Ensure that all build and test scripts are compatible with these environments.

---

22-23: Installation steps for dependencies have been tailored for each new Ubuntu version.

Verify that libwebkit2gtk-4.1-dev is the correct package for Ubuntu 24.04 as package names can vary between Ubuntu releases.

Also applies to: 26-28

---

44-51: Distinct test commands have been set up for Ubuntu 24.04 using specific compile-time tags.

Ensure that the -tags webkit2_41 is correctly configured in the build system to utilize the right version of WebKitGTK for Ubuntu 24.04.

---

85-85: Updated template testing matrix to include new Ubuntu versions and added specific build steps for Ubuntu 24.04.

It’s crucial to test across all specified templates to ensure that there are no platform-specific issues with the new Ubuntu versions, especially with the use of different tags in the build commands for Ubuntu 24.04.

Also applies to: 119-125, 136-143

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0107429 and 750d60a.

Files selected for processing (1)

• .github/workflows/build-and-test.yml (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• .github/workflows/build-and-test.yml