Fixing compatibility errors w/Gin and Windows.

[AnalogJ]

😬 Sorry I haven't opened a issue about these yet. They've been living in my branch for more than 6months at this point, made sense to move them upstream

Description

• The contentTypeSniffer struct is not compatible with the Gin response, which requires the http.CloseNotifier interface.
• Fixing a parsing error for syso options.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

• Windows
• macOS

Test Configuration

                                
          Wails Doctor          
                                

                                                                                                                                                                            
# System
┌──────────────────────────────┐
| Name          | MacOS        |
| Version       | 12.6         |
| ID            | 21G115       |
| Branding      | Monterey     |
| Platform      | darwin       |
| Architecture  | arm64        |
| Apple Silicon | true         |
| CPU           | Apple M1 Max |
| CPU           | Unknown      |
| GPU           | Unknown      |
| Memory        | Unknown      |
└──────────────────────────────┘

# Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.4                           |
| Go Version   | go1.22.4                                 |
| Revision     | ab06920e74473cb0e34bf2dfffdd8bda023f3ddc |
| Modified     | false                                    |
| -buildmode   | exe                                      |
| -compiler    | gc                                       |
| CGO_CFLAGS   |                                          |
| CGO_CPPFLAGS |                                          |
| CGO_CXXFLAGS |                                          |
| CGO_ENABLED  | 1                                        |
| CGO_LDFLAGS  |                                          |
| GOARCH       | arm64                                    |
| GOOS         | darwin                                   |
| vcs          | git                                      |
| vcs.modified | false                                    |
| vcs.revision | ab06920e74473cb0e34bf2dfffdd8bda023f3ddc |
| vcs.time     | 2024-06-08T22:28:38Z                     |
└─────────────────────────────────────────────────────────┘

# Dependencies
┌────────────────────────────────────────────────────────────────────────┐
| Xcode cli tools | 2395                                                 |
| npm             | 10.5.0                                               |
| *NSIS           | Not Installed. Install with `brew install makensis`. |
└─────────────────────── * - Optional Dependency ────────────────────────┘

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Checklist:

• I have updated website/src/pages/changelog.mdx with details of this PR
• My code follows the general coding style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[leaanthony]

Thanks for doing this. What's the parsing error?

[AnalogJ]

honestly, I don't even know any more. The http.CloseNotifier interface is still an issue, but I'm not quite sure why those syso changes were required.

It must be related to my generate command, but I'm not sure.

wails3 generate syso -arch {{.ARCH}} -icon icon.ico -manifest wails.exe.manifest -info info.json -out ../wails.syso

[leaanthony]

Are you ok if we take out the syso change? That line currently works fine in the default template.
Please could you also add an entry to the changelog located at mkdocs-website/docs/changelog.md?
Do you have a publicly sharable example of the gin integration you are doing? Would love to write a guide on it 🙏

[AnalogJ]

Done! ✅

• removed the syso changes
• Changelog entry

Do you have a publicly sharable example of the gin integration you are doing? Would love to write a guide on it 🙏

Unfortunately I don't, my desktop app is the paid version of my open-source fasten-onprem project.

But it's mostly just some custom setup and then calling:

	app := application.New(application.Options{
		Assets: application.AssetOptions{
			Middleware: FileServerMiddleware,
			Handler:    ginWebServerEngine.Handler(),
		},
		...
	}

[therealsamf]

Is this still in progress? I ran into same issue using echo and contentTypeSniffer not implementing http.Flusher interface.

The app panics here: https://github.com/labstack/echo/blob/master/response.go#L91