Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow builds for webkit2gtk-4.1 #3465

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

atterpac
Copy link
Member

@atterpac atterpac commented May 8, 2024

Description

This pr allows for v2 to build for Ubuntu 24.04 and any other OS releases coming out where webkit2gtk-4.0 is unavailable by adding the webkit2_41 tag

Fixes # (issue)

Type of change

  • [ X ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [ X ] Linux

Test Configuration

# Wails
Version         | v2.8.2
Revision        | 1193fe97997d62ec2a61665628ef072b944ad181
Modified        | true
Package Manager | apt

# System
┌─────────────────────────────────────────────────────────────────────────────────────────┐
| OS           | Ubuntu                                                                   |
| Version      | 24.04                                                                    |
| ID           | ubuntu                                                                   |
| Go Version   | go1.22.2                                                                 |
| Platform     | linux                                                                    |
| Architecture | amd64                                                                    |
| CPU          | 12th Gen Intel(R) Core(TM) i5-1235U                                      |
| GPU          | Alder Lake-UP3 GT2 [Iris Xe Graphics] (Intel Corporation) - Driver: i915 |
| Memory       | 7GB                                                                      |
└─────────────────────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌─────────────────────────────────────────────────────────────┐
| Dependency | Package Name    | Status    | Version          |
| *docker    | docker.io       | Available | 24.0.7-0ubuntu4  |
| gcc        | build-essential | Installed | 12.10ubuntu1     |
| libgtk-3   | libgtk-3-dev    | Installed | 3.24.41-4ubuntu1 |
| libwebkit  | Unknown         | Not Found |                  |
| npm        | npm             | Installed | 10.5.1           |
| *nsis      | nsis            | Available | 3.09-4ubuntu1    |
| pkg-config | pkg-config      | Installed | 1.8.1-2build1    |
└────────────────── * - Optional Dependency ──────────────────┘

tmclane
tmclane previously approved these changes May 8, 2024
Copy link
Member

@tmclane tmclane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tmclane tmclane dismissed their stale review May 8, 2024 18:31

Want to reapprove

Copy link
Member

@tmclane tmclane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to test workflow fix...

@tmclane tmclane requested a review from leaanthony May 8, 2024 19:58
@tmclane tmclane merged commit 05bdeb0 into wailsapp:master May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants