Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Specify how to handle the Fixed WebView Runtime. #3444

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Documentation: Specify how to handle the Fixed WebView Runtime. #3444

merged 3 commits into from
Jun 19, 2024

Conversation

ALizarazoTellez
Copy link
Contributor

Specify to the user that the WebView Runtime dependency must be extracted before being used.

Note

I am not an English speaker, so I apologize in advance for any language-related mistakes I may have made.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes incomplete documentation.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Irrelevant.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Specify to the user that the WebView dependency must be extracted before being used.
@leaanthony
Copy link
Member

Thanks for taking the time to write this. Could you please add it to the non-versioned docs here website/docs/guides/windows.mdx ? Thank you 🙏

@ALizarazoTellez
Copy link
Contributor Author

I don't know if I understood correctly, but it was just adding the content to the no versioned page? Or do I also have to remove it from the versioned page?

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@ALizarazoTellez
Copy link
Contributor Author

Done.

Copy link

sonarcloud bot commented Jun 19, 2024

@leaanthony leaanthony merged commit 517d8d7 into wailsapp:master Jun 19, 2024
11 checks passed
therealsamf pushed a commit to therealsamf/wails that referenced this pull request Aug 29, 2024
…sapp#3444)

* Update `windows.mdx`

Specify to the user that the WebView dependency must be extracted before being used.

* Update no versioned `windows.mdx`

* Update `changelog.mdx`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants