Correctly compute 'startURL' when using a frontend development server.

[joshdrake]

Description

Correctly compute startURL across multiple GetStartURL invocations when FRONTEND_DEVSERVER_URL is present.

Fixes #3298

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

• Windows
• macOS
• Linux

Test Configuration

Build Environment

Wails CLI | v3.0.0-alpha.3
Go Version | go1.22.0
Revision | 4467a1f
Modified | true
-buildmode | exe
-compiler | gc
CGO_CFLAGS |
CGO_CPPFLAGS |
CGO_CXXFLAGS |
CGO_ENABLED | 1
CGO_LDFLAGS |
DefaultGODEBUG | httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
GOAMD64 | v1
GOARCH | amd64
GOOS | linux
vcs | git
vcs.modified | true
vcs.revision | 4467a1f
vcs.time | 2024-03-04T11:38:21Z

System

Name | Fedora Linux
Version | 38
ID | fedora
Branding | 38 (Workstation Edition)
Platform | linux
Architecture | amd64
gcc | 13.2.1
libgtk-3 | 3.24.41
libwebkit | 2.42.5
npm | 10.2.3
pkg-config | 1.8.0
CPU | AMD Ryzen 5 7600X 6-Core Processor
GPU 1 | Raphael (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu
GPU 2 | Navi 23 [Radeon RX 6600/6600 XT/6600M] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu
Memory | 64GB

Diagnosis

SUCCESS Your system is ready for Wails development!

Checklist:

• I have updated website/src/pages/changelog.mdx with details of this PR
• My code follows the general coding style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[joshdrake]

I've added another commit that also fixes some incorrect behavior when provided an input URL. Previously, the input URL was parsed (unnecessarily) and then only the Path was used when re-constructing the startURL. This prevented any usage of eg: fragments, query strings, etc. in the URL provided via options.

The changes in #3273 introduced ResolveReference, but that addition was not related to the originally reported problem, which was due to mutation of baseURL in GetStartURL and multiple GetStartURL invocations. I've left ResolveReference behavior in place though (URL.Parse operates this way), and generally cleaned up the implementation.

[leaanthony]

Thank you! 🙏