-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- add -m(skip go mod tidy) build flag to dev command #3275
Conversation
WalkthroughThe recent update involves enhancing the Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- v2/cmd/wails/flags/build.go (1 hunks)
- v2/cmd/wails/flags/buildcommon.go (1 hunks)
- v2/cmd/wails/internal/dev/dev.go (1 hunks)
Files skipped from review due to trivial changes (1)
- v2/cmd/wails/flags/build.go
Additional comments: 2
v2/cmd/wails/flags/buildcommon.go (1)
- 12-12: The addition of the
SkipModTidy
field to theBuildCommon
struct is correctly implemented and aligns with the PR's objective to allow skipping thego mod tidy
operation. The field name, syntax, and struct tag are all appropriate.v2/cmd/wails/internal/dev/dev.go (1)
- 63-68: The conditional execution of
go mod tidy
based on theSkipModTidy
flag is correctly implemented. The logic, syntax, and error handling are all appropriate, aligning with the PR's objective to provide flexibility in managing Go module dependencies.
Thanks 🙏 Please could you add an entry to the changelog located at |
No problem, just wasn't quite sure where to add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Additional comments: 1
website/src/pages/changelog.mdx (1)
- 17-17: The changelog entry for the new
-m(skip go mod tidy)
flag is clear and concise. It correctly attributes the contribution to @te5se and links to the PR where this change was introduced. This entry follows the project's standards for documenting new features in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this! 🙏
Glad to pitch in :) |
Description
Adds functionality #(3269)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.Test Configuration
Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit
SkipModTidy
option for more consistent command-line flag handling.go mod tidy
command during the build process, enhancing flexibility for developers.