Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3 darwin] change hex values for arrow keys pulled from "Key Codes" app #3052

Closed

Conversation

jaybeecave
Copy link

@jaybeecave jaybeecave commented Nov 11, 2023

Description

Arrow keys are not working for OSX sonoma (wails doctor pasted below). Hex codes have been updated and were pulled from
Key Codes App

Bug fix (non-breaking change which fixes an issue)

Tested using the following accelerators

navigationMenu.Add("Previous Day").SetAccelerator("up").OnClick(func(ctx *application.Context) {

})
navigationMenu.Add("Next Day").SetAccelerator("down").OnClick(func(ctx *application.Context) {

})
navigationMenu.AddSeparator()
navigationMenu.Add("Prev 30 Seconds").SetAccelerator("left").OnClick(func(ctx *application.Context) {

})
navigationMenu.Add("Next 30 Seconds").SetAccelerator("right").OnClick(func(ctx *application.Context) {

})

Test Configuration

# Build Environment
Wails CLI    | v3.0.0-alpha.0                          
Go Version   | go1.21.1                                
Revision     | d9a5130311680b3b6de37d9e9a55ab0142f14c08
Modified     | false                                   
-buildmode   | exe                                     
-compiler    | gc                                      
CGO_CFLAGS   |                                         
CGO_CPPFLAGS |                                         
CGO_CXXFLAGS |                                         
CGO_ENABLED  | 1                                       
CGO_LDFLAGS  |                                         
GOAMD64      | v1                                      
GOARCH       | amd64                                   
GOOS         | darwin                                  
vcs          | git                                     
vcs.modified | false                                   
vcs.revision | d9a5130311680b3b6de37d9e9a55ab0142f14c08
vcs.time     | 2023-09-25T10:56:29Z                    

# System
Name            | MacOS                                   
Version         | 14.0                                    
ID              | 23A344                                  
Branding        | Sonoma                                  
Platform        | darwin                                  
Architecture    | amd64                                   
Apple Silicon   | unknown                                 
CPU             | Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Xcode cli tools | 2399                                    

Copy link

netlify bot commented Nov 11, 2023

👷 Deploy request for dapper-pastelito-9b5e5b pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7bce3a4

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

This was referenced Dec 17, 2023
@leaanthony
Copy link
Member

Completed by #3140

@leaanthony leaanthony closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants