Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disable window resize #2863

Merged

Conversation

lyimmi
Copy link
Contributor

@lyimmi lyimmi commented Aug 27, 2023

Description

This PR fixes disable window resize by setting the gtk_window_set_default_size when the window is created.

Fixes #2780

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on Ubuntu 23.04 with existing an new projects.

  • Windows
  • macOS
  • Linux

Test Configuration

# System

OS           | Ubuntu  
Version      | 23.04   
ID           | ubuntu  
Go Version   | go1.21.0
Platform     | linux   
Architecture | amd64   

# Wails

Version         | v2.5.1
Package Manager | apt   

# Dependencies

Dependency | Package Name          | Status    | Version                
*docker    | docker.io             | Installed | 24.0.5                 
gcc        | build-essential       | Installed | 12.9ubuntu3            
libgtk-3   | libgtk-3-dev          | Installed | 3.24.37-1ubuntu1       
libwebkit  | libwebkit2gtk-4.0-dev | Installed | 2.40.5-0ubuntu0.23.04.1
npm        | npm                   | Installed | 9.8.0                  
*nsis      | nsis                  | Installed | v3.08-3                
pkg-config | pkg-config            | Installed | 1.8.1-1ubuntu2  

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@lyimmi
Copy link
Contributor Author

lyimmi commented Aug 27, 2023

I goofed something up with the previous PR and made a new one to be safe, sorry!

@leaanthony
Copy link
Member

LGTM! Thanks for this @lyimmi

@leaanthony leaanthony merged commit 427e41f into wailsapp:master Aug 27, 2023
2 checks passed
@lyimmi lyimmi deleted the bugfix/2780_DisableResize_option_not_working branch August 28, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] DisableResize option not working
2 participants