-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] build hook command parsing #2836
Conversation
use `shlex`, rather than `strings` package, to split build command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. I noticed the shlex package is deprecated. Do you know of an alternative?
@leaanthony |
We can go with |
I just realised you didn't update the changelog... Please could you add an entry to the changelog located at |
Added changes for wailsapp#2836
@leaanthony added in #2868 |
I think there might be a few other cases of this bug in other places like |
Description
use
shlex
, rather thanstrings
package, to split pre/post-build commandType of change
Please delete options that are not relevant.
How Has This Been Tested?
Yes
Test Configuration
Wails CLI v2.5.1
System
Wails
Dependencies
* - Optional Dependency
Diagnosis
Your system is ready for Wails development!
♥ If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony
Checklist: