[options] Mergo doesn't play well with reference types #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove mergo and just use a simple hardcoded defaults approach.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployment failed with the following error: |
leaanthony
approved these changes
Mar 6, 2023
| @@ -148,7 +160,10 @@ func processMenus(appoptions *App) { | |||
| switch runtime.GOOS { | |||
| case "darwin": | |||
| if appoptions.Menu == nil { | |||
| appoptions.Menu = defaultMacMenu | |||
| appoptions.Menu = menu.NewMenuFromItems( | |||
There was a problem hiding this comment.
Was this change intended? Just wondering how it affected the behaviour. Perhaps we should remove the default variables if they are causing an issue?
There was a problem hiding this comment.
Yeah it was intended but not needed for the fix. It was just that after removing the default handling there was a default.go file with just the content of the defaultMacMenu. So I thought we could remove that and get rid of that almost empty default.go file.
|
Thanks for approving 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mergo and just use a simple hardcoded defaults approach.
Fixes #2450