[v2] frontend/runtime/wrapper: return function return value in runtime wrapper #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thanks so much for fixing this 🙏 . LGTM, would it be possible for you to also update the CHANGELOG in the website directory? |
zllovesuki
force-pushed
the
runtime_wrapper_fix
branch
from
41a8228
to
e237cf0
Compare
|
OK, I added the changelog. When can we cut a release with the bug fixes? |
stffabi
approved these changes
Mar 1, 2023
|
Awesome, thanks for updating the changelog. I'll merge it as soon as all the test builds have been finished.
@leaanthony and I talked about a new release over the weekend. There's one PR open which would need to be merged first, AFAIK. But I think we should be able to put out a new release soon. |
|
Yeah, let's get a release out shortly. I just need to tidy up all-contributors |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2433