Add EnableFraudulentWebsiteDetection to options #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leaanthony do you think it should be opt-in or opt-out? I tend it to be opt-in but that will change the behaviour of existing apps. |
I think it should not change behaviour for v2 so that it doesn't break anything and for v3 we can change the default. |
stffabi
force-pushed
the
feature/fraudulentwarning-optin
branch
from
2e918e1
to
8cf54fc
Compare
|
I've updated the PR to invert the logic. @leaanthony would you mind taking another look? |
stffabi
changed the title
|
I had a think about this overnight.... I don't recall anyone reporting this warning so maybe disabling by default is actually fine? |
This allows to explicitly opt-in to scan services for fraudulent content, such as malware or phishing attempts.
stffabi
force-pushed
the
feature/fraudulentwarning-optin
branch
from
8cf54fc
to
22f51da
Compare
stffabi
changed the title
|
Reverted back to the original version. |
|
Nice one! Thanks for doing that 🙏 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to explicitly opt-in to scan services for fraudulent
content, such as malware or phishing attempts.
Fixes #2163