-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend:dev:install
configuration
#1666
Add frontend:dev:install
configuration
#1666
Conversation
This looks good to me! If @stffabi is happy, let's go! |
Thanks @LGiki for this. LGTM, there's just one thing which we might also need to change. During the build process we also execute an install command before the frontend is getting build. Currently we use the wails/v2/pkg/commands/build/base.go Lines 516 to 519 in d5574ba
What do you think @leaanthony ? |
Yeah, good call. @LGiki this is what we do for the build command: wails/v2/pkg/commands/build/base.go Lines 533 to 547 in d5574ba
|
I'm thinking about how we can also change |
…f it has been defined) to install the dependencies
Thanks, I've pushed a new commit that uses the same logic to handle the install command when building the frontend if it's called for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one comment 👍👍👍
v2/pkg/commands/build/base.go
Outdated
@@ -513,17 +513,27 @@ func (b *BaseBuilder) BuildFrontend(outputLogger *clilogger.CLILogger) error { | |||
frontendDir := filepath.Join(b.projectData.Path, "frontend") | |||
|
|||
// Check there is an 'InstallCommand' provided in wails.json | |||
if b.projectData.InstallCommand == "" { | |||
var installCommand string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified with the helper method you created! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks, I've simplified the logic of determining the installation command.
That'd be great if you could! I would do something like we've done already and check |
Yeah, I will create a PR to do this. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , thanks so much for the time you have put into this.
Add a
frontend:dev:install
configuration in wails.json to specify the dev dependencies installation command and update the docs.Fixes #1663