Add support for production log levels #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
413c01a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0113ec70.wails-website.pages.dev |
| Branch Preview URL: | https://feature-production-log-level.wails-website.pages.dev |
stffabi
reviewed
Jul 14, 2022
| if !IsDebug() { | ||
| myLogger.SetLogLevel(pkgLog.ERROR) | ||
| } | ||
| myLogger.SetLogLevel(appoptions.LogLevelProduction) |
There was a problem hiding this comment.
Doesn't this change the log level always to the production one, even when using '--debug' build?
There was a problem hiding this comment.
Ah, yeah, nice catch. It should be using the standard level defined for that else this ☝️
There was a problem hiding this comment.
Pushed fix to master. Thanks for picking that up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the developer to set the log level when running in production. Currently hardcoded to
ERROR.