Add missing className to input in React and Preact templates #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaanthony
requested changes
May 22, 2022
There was a problem hiding this comment.
Thanks for taking the time to do this 🙏 The templates are generated using the generate.go script (I can't link as I'm on my phone). Next time we regenerate we will lose this change. If you could update the templates that exist in generate/assets then we will keep the change next time we generate. Thanks
edwardbrowncross
force-pushed
the
master
branch
2 times, most recently
from
57a6ba0
to
e46d647
Compare
stffabi
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS styling is not being applied to the input field in the hello world templates for React and Preact because the input tag is missing the class identifier present in the templates for the other frameworks.