Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2, linux] Make sure to execute the menu callbacks on a new goroutine #1403

Merged
merged 2 commits into from
May 17, 2022
Merged

[v2, linux] Make sure to execute the menu callbacks on a new goroutine #1403

merged 2 commits into from
May 17, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented May 17, 2022

Fixes #1402

@stffabi stffabi requested a review from leaanthony May 17, 2022 07:13
@stffabi stffabi mentioned this pull request May 17, 2022
Closed
@stffabi stffabi marked this pull request as ready for review May 17, 2022 08:05
@stffabi stffabi enabled auto-merge (squash) May 17, 2022 08:06
@stffabi stffabi changed the title [v2, linux] Make sure to excute the menu callbacks on a new goroutine [v2, linux] Make sure to execute the menu callbacks on a new goroutine May 17, 2022
@stffabi stffabi disabled auto-merge May 17, 2022 08:08
@stffabi stffabi enabled auto-merge (squash) May 17, 2022 08:08
leaanthony
leaanthony approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really nice job 👍

@stffabi stffabi merged commit c97e1c5 into wailsapp:master May 17, 2022
@stffabi stffabi deleted the feature/linux-menu-callback-new-thread branch May 17, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v2] runtime.SomeDialog causes application to crash on linux
2 participants
@stffabi @leaanthony