Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2, nsis] Seems like / as path separator works only for some directives in a cross platform way #1227

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Mar 8, 2022

Especially the File directive seems not to work with a / on
Windows. Whereas \ works for all directives and on all platforms.
So the \ in NSIS can be used also on Linux and MacOS.

Closes #1226

…tives in a cross platform way

Especially the File directive seems not to work with a `/` on
Windows. Whereas `\` works for all directives and on all platforms.
So the `\` in NSIS can be used also on Linux and MacOS.
@TheFranconianCoder
Copy link

Works for me.

@stffabi stffabi marked this pull request as ready for review March 8, 2022 08:38
@stffabi
Copy link
Collaborator Author

stffabi commented Mar 8, 2022

Awesome, thanks so much for testing @sebastian0x62.

@leaanthony I think we are good to go.

@leaanthony
Copy link
Member

Nice job!

@leaanthony leaanthony merged commit c5c0617 into wailsapp:master Mar 8, 2022
@stffabi stffabi deleted the feature/nsis-backslash branch March 8, 2022 09:58
leaanthony pushed a commit that referenced this pull request Mar 8, 2022
…tives in a cross platform way (#1227)

Especially the File directive seems not to work with a `/` on
Windows. Whereas `\` works for all directives and on all platforms.
So the `\` in NSIS can be used also on Linux and MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSIS Option gives error about WebView2 setup file
3 participants