refactor(cli): optimize default templates #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stffabi
requested changes
Mar 6, 2022
There was a problem hiding this comment.
Awesome @misitebao, thanks for all the hard work you've put into this.
I'm not an frontend expert, so I have only left a comment regarding the assetdir entry in wails.json.
v2/cmd/wails/internal/commands/initialise/templates/templates/svelte/wails.tmpl.json
Outdated
Show resolved
Hide resolved
v2/cmd/wails/internal/commands/initialise/templates/templates/vanilla/wails.tmpl.json
Outdated
Show resolved
Hide resolved
Manually specified values are removed as the application will automatically infer from embed.FS.
leaanthony
requested changes
Mar 6, 2022
v2/cmd/wails/internal/commands/generate/template/base/frontend/dist/index.html
Outdated
Show resolved
Hide resolved
v2/cmd/wails/internal/commands/generate/template/base/frontend/dist/index.html
Outdated
Show resolved
Hide resolved
leaanthony
reviewed
Mar 6, 2022
v2/cmd/wails/internal/commands/initialise/templates/templates/svelte/frontend/README.md
Outdated
Show resolved
Hide resolved
leaanthony
reviewed
Mar 6, 2022
...ails/internal/commands/initialise/templates/templates/svelte/frontend/package-lock.tmpl.json
Show resolved
Hide resolved
…svelte/frontend/README.md
leaanthony
added a commit
that referenced
this pull request
Mar 8, 2022
* refactor(cli): optimize the template that generates the base template * refactor: optimize the default vanilla template * feat(cli): add script to default vanilla template * refactor(cli): refactor default svelte template and add script * fix: remove manually added assetdir fields Manually specified values are removed as the application will automatically infer from embed.FS. * fix: remove drag attribute within page * Update v2/cmd/wails/internal/commands/initialise/templates/templates/svelte/frontend/README.md Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wails generate templatevanillatemplates and add scriptssveltetemplate with Vite and add scriptThe template generated by the
basetemplate keeps the same UI and function as thevanillaandsveltetemplates. All updates are only tested on windows.