Skip to content

Commit

Permalink
Updated Id type to ID for Screen (#3779)
Browse files Browse the repository at this point in the history
* 🏷️ Updated `Id` type to `ID` for `Screen`

* 📝 Updated changelog
  • Loading branch information
Etesam913 authored Sep 27, 2024
1 parent df091f0 commit 77b8132
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
3 changes: 2 additions & 1 deletion mkdocs-website/docs/en/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Taskfile refactor by [leaanthony](https://github.com/leaanthony) in [#3748](https://github.com/wailsapp/wails/pull/3748)
- Upgrade to `go-webview2` v1.0.16 by [leaanthony](https://github.com/leaanthony)
- Fixed `Screen` type to include `ID` not `Id` by [etesam913](https://github.com/etesam913) in [#3778](https://github.com/wailsapp/wails/pull/3778)

## v3.0.0-alpha.7 - 2024-09-18

### Added
- [windows] New DIP system for Enhanced High DPI Monitor Support by [mmghv](https://github.com/mmghv) in [#3665](https://github.com/wailsapp/wails/pull/3665)
- [windows] Window class name option by [windom](https://github.com/windom/) in [#3682](https://github.com/wailsapp/wails/pull/3682)
- [windows] Window class name option by [windom](https://github.com/windom/) in [#3682](https://github.com/wailsapp/wails/pull/3682)
- Services have been expanded to provide plugin functionality. By [atterpac](https://github.com/atterpac) and [leaanthony](https://github.com/leaanthony) in [#3570](https://github.com/wailsapp/wails/pull/3570)

### Changed
Expand Down
9 changes: 3 additions & 6 deletions v3/internal/runtime/desktop/@wailsio/runtime/src/screens.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ The electron alternative for Go
* @property {number} Height - The height.
*/


/**
* @typedef {Object} Rect
* @property {number} X - The X coordinate of the origin.
Expand All @@ -25,10 +24,9 @@ The electron alternative for Go
* @property {number} Height - The height of the rectangle.
*/


/**
* @typedef {Object} Screen
* @property {string} Id - Unique identifier for the screen.
* @property {string} ID - Unique identifier for the screen.
* @property {string} Name - Human readable name of the screen.
* @property {number} ScaleFactor - The scale factor of the screen (DPI/96). 1 = standard DPI, 2 = HiDPI (Retina), etc.
* @property {number} X - The X coordinate of the screen.
Expand All @@ -42,9 +40,8 @@ The electron alternative for Go
* @property {number} Rotation - The rotation of the screen.
*/


import {newRuntimeCallerWithID, objectNames} from "./runtime";
const call = newRuntimeCallerWithID(objectNames.Screens, '');
import { newRuntimeCallerWithID, objectNames } from "./runtime";
const call = newRuntimeCallerWithID(objectNames.Screens, "");

const getAll = 0;
const getPrimary = 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export type Screen = {
/**
* - Unique identifier for the screen.
*/
Id: string;
ID: string;
/**
* - Human readable name of the screen.
*/
Expand Down

0 comments on commit 77b8132

Please sign in to comment.