Return .standard_name field from ssl:getCipherInfo #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
force-pushed
the
std-cipher-names
branch
from
e9baf9e to
61643aa
Compare
daurnimator
added a commit
to daurnimator/lua-http
that referenced
this pull request
Jul 13, 2018
This alleviates the need for our own standard name to openssl name map for ciphers. Requires wahern/luaossl#142
daurnimator
commented
Jul 13, 2018
src/openssl.c
Outdated
| {0x001A, "SSL_DH_anon_WITH_DES_CBC_SHA"}, | ||
| {0x001B, "SSL_DH_anon_WITH_3DES_EDE_CBC_SHA"}, | ||
| {0x001D, "SSL_FORTEZZA_KEA_WITH_FORTEZZA_CBC_SHA"}, | ||
| {0x001E, "SSL_FORTEZZA_KEA_WITH_RC4_128_SHA"}, |
There was a problem hiding this comment.
Should this be TLS_KRB5_WITH_DES_CBC_SHA? See https://github.com/openssl/openssl/pull/1743/files and daurnimator/lua-http#116 (comment)
daurnimator
force-pushed
the
std-cipher-names
branch
from
61643aa to
f355d23
Compare
daurnimator
commented
Jul 13, 2018
src/openssl.c
Outdated
| {0x001A, "TLS_DH_anon_WITH_DES_CBC_SHA"}, | ||
| {0x001B, "TLS_DH_anon_WITH_3DES_EDE_CBC_SHA"}, | ||
| {0x001D, "TLS_FORTEZZA_KEA_WITH_FORTEZZA_CBC_SHA"}, | ||
| {0x001E, "TLS_FORTEZZA_KEA_WITH_RC4_128_SHA"}, |
There was a problem hiding this comment.
Awaiting answer to openssl/openssl#6710
daurnimator
force-pushed
the
std-cipher-names
branch
from
f355d23 to
2d01cf6
Compare
According to openssl/openssl#6710 patches exist(ed) for Kerberos, while FORTEZZA_KEA_WITH_RC4_128_SHA was never implemented (and not likely to be in future)
daurnimator
force-pushed
the
std-cipher-names
branch
from
b14a9db to
e75a942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #118
SSL_CIPHER_standard_namehas been around for a long time, but only when OpenSSL was compiled with the rarely used--enable-traceoption. It's expected the OpenSSL 1.1.1 will make it unconditional (via openssl/openssl#3859)This PR includes a backwards compatible shim for <= 1.1.0