Skip to content

Conversation

@Dharma-09
Copy link
Contributor

fixed #5471

  • Add pinterest embded urls support .
  • Let me know if anymore changes required.

@squash-labs
Copy link

squash-labs bot commented Mar 15, 2022

Manage this branch in Squash

Test this branch here: https://dharma-09pinterest-embed-suppo-elpwe.squash.io

@thibaudcolas thibaudcolas added the GSOC Google Summer of Code label Mar 16, 2022
@Dharma-09
Copy link
Contributor Author

Hey @thibaudcolas any comment on this??

Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dharma-09 thanks so much for taking the time to contribute but please advise how you tested it.

Screen Shot 2022-03-22 at 8 31 14 am

I checked out this branch, tried entering
https://www.pinterest.com/villabalicom/must-visit-places-in-bali/ and I got an error

It appears Pinterest is also adding country domains to their redirects, I originally tried
https://www.pinterest.com.au/viatortravel/bali-things-to-do/ and got the same error.

I might be missing something but please can you update the original request or the PR description on how you expect this to work (maybe some example URLs and then a screenshot).

@Dharma-09
Copy link
Contributor Author

@lb- I have implemented pull request and add some regex.Error occurs because of bed regex.Now, it's working.You can review it now 🚀.

  • Here is urls which I am using for demo purpose.
 {% load wagtailembeds_tags %}
        {# Embed a Pinterest_image #}
        {% embed 'https://www.pinterest.com.au/viatortravel/bali-things-to-do/ ' %}
        {% embed 'https://in.pinterest.com/villabalicom/must-visit-places-in-bali/' %}
  • Here is a screenshot for understanding how it work actually.

pinterest_url

@lb-
Copy link
Member

lb- commented Mar 23, 2022

@Dharma-09 awesome. I'll take another look and hopefully can plan a trip to Bali haha.

@lb- lb- self-requested a review March 23, 2022 21:06
@lb- lb- force-pushed the Pinterest_embed_support branch from a679854 to a86e257 Compare March 23, 2022 22:06
@lb- lb- force-pushed the Pinterest_embed_support branch from a86e257 to 34d271c Compare March 23, 2022 22:08
Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Dharma-09 - I made a slight tweak to the regex to allow other TLDs but validated fine this time round.

I have put your name on the contributors list 'Dharmik Gangani' - please let me know if you wanted your name listed differently.

Will merge in shortly, congrats on making your first contribution to Wagtail.

Thank you!

@lb- lb- merged commit d0133d5 into wagtail:main Mar 23, 2022
@Dharma-09
Copy link
Contributor Author

Thanks @lb- Looking for more contribution in wagtail.

@kaedroho kaedroho changed the title Pinterest_embed_support Pinterest embed support Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:Embeds GSOC Google Summer of Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Pinterest embeds

3 participants