-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colors for compatibility with the dark theme #701
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 47 47
Lines 3905 3905
Branches 579 579
=======================================
Hits 3643 3643
Misses 152 152
Partials 110 110 ☔ View full report in Codecov by Sentry. |
Hey @Spikenn, Would be good to have some screenshots -- before & after with the dark theme, and how the changes look with Wagtail 4.1 |
Hi @zerolab Wagtail 4.1.6 - some CSS variables are missing |
Thank you for that, the UI does look much better in dark mode with these changes. It would be good to add the missing CSS variables for 4.1 as that is our long term support version and it would be unfair to make the experience worse |
@zerolab I added fallback values, now it looks better. |
That is most excellent, thank you @Spikenn Will test locally this evening and if all is good, will merge and package it all up for a release |
By way of update -- this needs more work on consistency. I am chipping away slowly at it. May be a Friday release |
v1.5.1 is now published |
No description provided.