Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors for compatibility with the dark theme #701

Closed
wants to merge 3 commits into from

Conversation

tspnn
Copy link
Contributor

@tspnn tspnn commented Jun 7, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1e781c6) 93.29% compared to head (00eb7a5) 93.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          47       47           
  Lines        3905     3905           
  Branches      579      579           
=======================================
  Hits         3643     3643           
  Misses        152      152           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zerolab
Copy link
Collaborator

zerolab commented Jun 7, 2023

Hey @Spikenn,

Would be good to have some screenshots -- before & after with the dark theme, and how the changes look with Wagtail 4.1

@tspnn
Copy link
Contributor Author

tspnn commented Jun 7, 2023

@zerolab
Copy link
Collaborator

zerolab commented Jun 7, 2023

Thank you for that, the UI does look much better in dark mode with these changes. It would be good to add the missing CSS variables for 4.1 as that is our long term support version and it would be unfair to make the experience worse

@tspnn
Copy link
Contributor Author

tspnn commented Jun 7, 2023

@zerolab I added fallback values, now it looks better.

Wagtail 4.1.6

@zerolab
Copy link
Collaborator

zerolab commented Jun 7, 2023

That is most excellent, thank you @Spikenn

Will test locally this evening and if all is good, will merge and package it all up for a release

@zerolab
Copy link
Collaborator

zerolab commented Jun 8, 2023

By way of update -- this needs more work on consistency. I am chipping away slowly at it. May be a Friday release

@zerolab
Copy link
Collaborator

zerolab commented Jun 11, 2023

Merged manually in b60a600 + parents.
Thank you @Spikenn

@zerolab zerolab closed this Jun 11, 2023
@zerolab
Copy link
Collaborator

zerolab commented Jun 11, 2023

v1.5.1 is now published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants