Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename imageChosen, documentChosen to chosen #650

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Rename imageChosen, documentChosen to chosen #650

merged 1 commit into from
Nov 29, 2022

Conversation

tspnn
Copy link
Contributor

@tspnn tspnn commented Nov 10, 2022

Fixes #649

After these commits choosers in the wagtail_localize didn't work correctly:
wagtail/wagtail@157f767
wagtail/wagtail@6dba0cf

@codecov-commenter
Copy link

Codecov Report

Base: 91.73% // Head: 91.73% // No change to project coverage 👍

Coverage data is based on head (e7cd8fc) compared to base (1e1f72f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          46       46           
  Lines        3983     3983           
  Branches      604      604           
=======================================
  Hits         3654     3654           
  Misses        195      195           
  Partials      134      134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tspnn
Copy link
Contributor Author

tspnn commented Nov 28, 2022

@zerolab any news on this?

@zerolab zerolab merged commit 9120739 into wagtail:main Nov 29, 2022
@zerolab
Copy link
Collaborator

zerolab commented Nov 29, 2022

Hey @Spikenn merged and releases v1.3.3
Sorry for the delay. Live got in the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosers don't work when translating a page
3 participants