Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pre Wagtail 2.15 support #617

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Drop pre Wagtail 2.15 support #617

merged 5 commits into from
Sep 23, 2022

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Sep 20, 2022

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Base: 91.06% // Head: 91.80% // Increases project coverage by +0.74% 🎉

Coverage data is based on head (943bce3) compared to base (0291a48).
Patch coverage: 91.42% of modified lines in pull request are covered.

❗ Current head 943bce3 differs from pull request most recent head 21d5d1c. Consider uploading reports for the commit 21d5d1c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   91.06%   91.80%   +0.74%     
==========================================
  Files          49       46       -3     
  Lines        3971     3916      -55     
  Branches      606      593      -13     
==========================================
- Hits         3616     3595      -21     
+ Misses        209      188      -21     
+ Partials      146      133      -13     
Impacted Files Coverage Δ
wagtail_localize/modeladmin/views.py 98.09% <ø> (+1.76%) ⬆️
wagtail_localize/models.py 95.42% <0.00%> (ø)
wagtail_localize/version.py 83.33% <ø> (-1.67%) ⬇️
wagtail_localize/views/convert.py 71.62% <0.00%> (ø)
wagtail_localize/__init__.py 100.00% <100.00%> (+40.00%) ⬆️
wagtail_localize/test/models.py 99.09% <100.00%> (+1.30%) ⬆️
wagtail_localize/test/settings.py 100.00% <100.00%> (+2.94%) ⬆️
wagtail_localize/wagtail_hooks.py 87.17% <100.00%> (+8.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

<script src="{% versioned_static 'wagtaildocs/js/document-chooser-modal.js' %}"></script>
<script src="{% versioned_static 'wagtaildocs/js/document-chooser.js' %}"></script>
<script src="{% versioned_static 'wagtailadmin/js/chooser-modal.js' %}"></script>
<script src="{% versioned_static 'wagtailsnippets/js/snippet-chooser.js' %}"></script>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering we redirect users to edit choosers, rather than allow them to choose another one I am not sure we need these, but that's for another PR

@zerolab zerolab merged commit 4c2af1a into main Sep 23, 2022
@zerolab zerolab deleted the chore/drop-pre-wagtail2.15 branch September 23, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants