-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mechanism for plugging in task queues #549
Conversation
@@ -57,9 +53,7 @@ def __init__(self, instance, *args, **kwargs): | |||
|
|||
# Don't count page aliases as existing translations. We can convert aliases into properly translated pages | |||
if isinstance(instance, Page): | |||
existing_translations = existing_translations.exclude( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: pre-commit install && pre-commit run black --all-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a cursory review. Got a few comments. Will aim to do a full review later.
Needs tests for the queue changes
I had a quick read over this. This is a cool feature 🎉 No specific comments on the code, but I think you can backport |
@kaedroho conflicting test app migrations. |
Based on RFC 72: wagtail/rfcs#72 This allows translating subtrees and synchronising locale trees to be performed by a background worker.
To work around an issue with Pickling pages which makes it difficult to use Django RQ
Rebased and test app migrations regenerated |
@kaedroho drop the |
Fixed the |
This implements a lightweight tasks API that allows heavy tasks like translating subtrees and synchronising locale trees to be performed by a background worker.
The API is subset of the background workers API that's proposed for Wagtail core in RFC 72: wagtail/rfcs#72. So hopefully this would be easy to port over to the official core implementation later on.
This feature is sponsored by YouGov.