-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation submit/update form components #491
Translation submit/update form components #491
Conversation
baed on the `wagtail_localize.locales.views.ComponentManager`
2acdd61
to
6b0fc39
Compare
For reasons unknown to mankind, eslint is failing on pre-commit
6b0fc39
to
e24f0b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 93.02% 92.82% -0.21%
==========================================
Files 35 36 +1
Lines 2868 2981 +113
Branches 449 467 +18
==========================================
+ Hits 2668 2767 +99
- Misses 104 114 +10
- Partials 96 100 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, nice work!
This PR provides a mechanism to add new form components to the submit/update translations views.
It takes the existing mechanism used on the locale edit forms
When submitting a translation we can get one or more translation sources with at least one corresponding translation sources. This should be accounted for by hte new
TranslationComponentManager
.New component registration can be done using the new
register_translation_component
decoratorDid not yet add documentation as
register_locale_component
is not documented. Let's discuss