Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure field level validation runs when translating snippets #427

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

kaedroho
Copy link
Contributor

Fixes #426

@kaedroho kaedroho added the type:bug Something isn't working label Jun 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #427 (eecbb9a) into main (1d76adf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files          35       35           
  Lines        2800     2802    +2     
  Branches      445      445           
=======================================
+ Hits         2606     2608    +2     
  Misses         98       98           
  Partials       96       96           
Impacted Files Coverage Δ
wagtail_localize/models.py 95.85% <100.00%> (+<0.01%) ⬆️
wagtail_localize/test/models.py 97.59% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d76adf...eecbb9a. Read the comment docs.

@kaedroho kaedroho force-pushed the 426-snippet-field-validation branch from 6e0a913 to 78186e0 Compare July 2, 2021 11:40
@kaedroho kaedroho force-pushed the 426-snippet-field-validation branch from 78186e0 to eecbb9a Compare July 2, 2021 11:48
@kaedroho kaedroho merged commit f588005 into main Jul 2, 2021
@kaedroho kaedroho deleted the 426-snippet-field-validation branch July 2, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_git crashes when importing snippet translations that are too long
3 participants