Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend tooling to use Node 20 #273

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

lb-
Copy link
Member

@lb- lb- commented Nov 12, 2023

Ensure we are on the latest LTS of Node for frontend tooling.

See wagtail/wagtail#11141 (Wagtail core update)

@lb- lb- added the dependencies Pull requests that update a dependency file label Nov 12, 2023
@lb-
Copy link
Member Author

lb- commented Nov 12, 2023

@lb-
Copy link
Member Author

lb- commented Jan 26, 2024

Ok. We might be able to use Node 20 now in Vercel.

https://vercel.com/changelog/nodejs-20

@lb-
Copy link
Member Author

lb- commented Jan 26, 2024

OK not sure here, will have to review again later.

Changing Vercel to Node 20 was breaking all the builds so I have just turned it back off for now.

Warning: Detected "engines": { "node": ">=20" } in your `package.json` that will automatically upgrade when a new major Node.js Version is released. Learn More: http://vercel.link/node-version
Error: Command "npm install && python3 -m pip install -r requirements.txt && pip install "urllib3<2" && python3 -m pip install -e ." exited with 1

@lb- lb- added the needs work Has been reviewed and changes have been requested label Jan 26, 2024
@laymonage
Copy link
Member

laymonage commented Feb 15, 2024

Oops, I didn't see that we don't use Node 20 yet. I updated the RTD config to use Node 20 in #284 , builds OK (with some warnings) but I assume we'll want to update it anyway.

@lb-
Copy link
Member Author

lb- commented Feb 17, 2024

I think that's fine, it's just Vercel taking a bit to make their Node 20 support official.

Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lb- 👍

I'm doing major spring cleaning on sphinx-wagtail-theme today so I will merge this now.

@Stormheg Stormheg merged commit 9d0986e into wagtail:main Mar 7, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs work Has been reviewed and changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants