Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from yarn to npm for JS package management #190

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Move from yarn to npm for JS package management #190

merged 1 commit into from
Oct 24, 2022
+15,077 −4,695

Conversation

lb-
Copy link
Member

@lb- lb- commented Oct 24, 2022 •
edited
Loading

@lb- lb- force-pushed the feature/111-move-from-yarn-to-npm branch from 67e974b to b62075f Compare October 24, 2022 21:51
@lb-
Replace yarn with npm
b7cb59c 
- NPM is less likely to cause major backwards compatibility issues, is more familiar to developers (especially in the Wagtail ecosystem)
- NPM tooling comes built in with node installation so does not add another dependency, it also has the ability to install related deps and check security issues easier
- Fixes wagtail#111
- Fixes wagtail#151
@lb- lb- force-pushed the feature/111-move-from-yarn-to-npm branch from b62075f to b7cb59c Compare October 24, 2022 22:06
@lb-
Copy link
Member Author

lb- commented Oct 24, 2022

CI running great, gitpod running great - will mark this as ready.

@lb- lb- marked this pull request as ready for review October 24, 2022 22:06
allcaps
allcaps approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@allcaps allcaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! Great.

@allcaps allcaps merged commit 58daaa3 into wagtail:main Oct 24, 2022
@thibaudcolas thibaudcolas added this to the Before launch milestone Oct 25, 2022
@lb- lb- deleted the feature/111-move-from-yarn-to-npm branch October 26, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allcaps allcaps allcaps approved these changes

Assignees

@lb- lb-

Labels
None yet
Projects
No open projects
📚 Editor Guide launch
Status: ✅ Done
Milestone
Before launch
Development

Successfully merging this pull request may close these issues.

Replace Yarn with NPM for package management
3 participants
@lb- @allcaps @thibaudcolas