Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gitpod #11

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Add Gitpod #11

merged 1 commit into from
Jul 10, 2022

Conversation

allcaps
Copy link
Member

@allcaps allcaps commented Jul 5, 2022

@allcaps allcaps requested a review from Hitansh-Shah July 5, 2022 06:38
Hitansh-Shah
Hitansh-Shah approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@Hitansh-Shah Hitansh-Shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of apps/guide/settings/local.py.example? Rest LGTM.

@allcaps
Copy link
Member Author

allcaps commented Jul 9, 2022

What is the purpose of apps/guide/settings/local.py.example? Rest LGTM.

Each settings file ends with a try: import local expecting a local.py. The local.py.example most often is provided as an example file to showcase possible settings.

local.py.example seems off topic in this PR, so I removed it.

@Hitansh-Shah
Copy link
Contributor

Thanks @allcaps 👍

@allcaps allcaps merged commit 38df827 into wagtail:main Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hitansh-Shah Hitansh-Shah Hitansh-Shah approved these changes

Assignees

@allcaps allcaps

Labels
None yet
Projects
No open projects
Editor guide - GSoC
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allcaps @Hitansh-Shah