Fix broken AVIF support when used with Pillow 11.2.1 #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pillow 11.2.1 added native AVIF support but it requires building Pillow from source to work correctly. Unfortunately, depending on the order of imports, the 'incomplete' AVIF implementation of Pillow is used instead of pillow_heif. Add a test to confirm this scenario.
Thanks to Andrew Murray for the suggestion!
When pillow_heif v0.23 will be released AVIF support will no longer be included as Pillow now has it natively. We still rely on pillow_heif for our AVIF support since the Pillow 11.2.1 wheels don't include the necessary binaries. See also: wagtail#166
Merged
zerolab
added
the
component: Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See @laymonage's comment: python-pillow/Pillow#8886 (comment)
This applies the fix proposed on that discussion by Andrew Murray - thank you
Also pinning pillow_heif for now so our users don't end up pulling in a version of that package that no longer has AVIF support. We should either move to https://github.com/fdintino/pillow-avif-plugin (unsure what the future of that plugin looks like now that AVIF support has technically shipped in Pillow) or wait for Pillow 11.3.0 due for release next quarter which has the potential of shipping full AVIF support
See also #167 for more background