Move formula to homebrew-core

[chenrui333]

I think it would be nice to add this formula into homebrew-core. So I went ahead creating a PR for it, Homebrew/homebrew-core#42492.

[wagoodman]

Thanks @chenrui333 . I don't have a mac handy, but it seems that I can help out on a linux box just fine too. Let me know if you'd like help troubleshooting the issue your seeing here https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/45745/console . (just for tracking, this addresses #97 )

[chenrui333]

Yeah, my machine is Mac, I have tested locally before the submission, not quite sure why it fails in the CI. I will double check now.

[chenrui333]

@wagoodman, Given the homebrew-core PR build issue reolsved, I went ahead of creating a migration PR for homebrew-dive as well (which would depend on the homebrew-core PR).

[chenrui333]

@wagoodman the PR Homebrew/homebrew-core#42492 has been merged, I think we can merge this one now :)

[md5]

@chenrui333 Any chance the docker dependency can be removed? I have Docker for Mac installed, which I believe is still the recommended way to install Docker on a Mac, and I do not want to install the docker formula from Homebrew as well...

From this perspective, the previous tap created by @wagoodman was preferable. I have installed it using these commands:

$ brew tap wagoodman/dive
$ brew install wagoodman/dive/dive

BTW, this tool looks great and I can't wait to use it more thoroughly. I'm also happy to see it in Homebrew by default, I just don't want to see the docker dependency.

[chenrui333]

Sure, I can remove that, I was thinking more from runtime dependency perspective. I will do it now.

[chenrui333]

@md5 I have removed the docker dependency in the homebrew-core and PR got merged. :)

[md5]

Thanks!

[wagoodman]

@chenrui333 thanks for the homebrew update! Indeed the docker dependency is optional. As long as you can connect to a docker socket somewhere, you don't necessarily need the docker client.

[wagoodman]

Sorry for the delay, thanks for your time @chenrui333

[chenrui333]

No worries, thanks for the merge! 🎉